Skip to content

ci: fail release early when signing secrets are missing #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fly1d merged 1 commit into from
Aug 18, 2026
Merged

ci: fail release early when signing secrets are missing #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,44 @@ permissions:
contents: write

jobs:
preflight:
name: Verify signing configuration
runs-on: ubuntu-latest
timeout-minutes: 5
permissions:
contents: read
steps:
- name: Check required Apple secrets
env:
APPLE_CERTIFICATE: ${{ secrets.APPLE_CERTIFICATE }}
APPLE_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
APPLE_SIGNING_IDENTITY: ${{ secrets.APPLE_SIGNING_IDENTITY }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_PASSWORD: ${{ secrets.APPLE_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
shell: bash
run: |
set -euo pipefail
missing=()
for secret_name in \
APPLE_CERTIFICATE \
APPLE_CERTIFICATE_PASSWORD \
APPLE_SIGNING_IDENTITY \
APPLE_ID \
APPLE_PASSWORD \
APPLE_TEAM_ID; do
if [[ -z "${!secret_name:-}" ]]; then
missing+=("$secret_name")
fi
done
if (( ${#missing[@]} > 0 )); then
printf 'Missing required release secrets: %s\n' "${missing[*]}"
exit 1
fi
echo "All required release secrets are configured."

build-macos:
needs: preflight
runs-on: macos-14
timeout-minutes: 45
steps:
Expand Down
2 changes: 2 additions & 0 deletions docs/releasing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ Public macOS artifacts should not be published without Apple signing and notariz
- `APPLE_PASSWORD`
- `APPLE_TEAM_ID`

The release workflow checks that all six secrets are present before reserving a macOS runner. It never prints their values; a missing secret stops the workflow with the secret name and setup guidance.

Unsigned builds are suitable only for local development and internal beta testing because Gatekeeper will warn users.

## Rollback
Expand Down