feat: add configurable macOS selection shortcut - #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Option + KRisk
Verification
npm run check(34 tests, typecheck, production build)npm run test:smoke(5 passed, 1 desktop-only viewport test skipped by design)npm run test:site(12 passed)npm run desktop:check(Rust fmt, Clippy, 8 tests, cargo check).appbuildReview Notes
Bare
Kis intentionally rejected because a Carbon global shortcut would consume normal typing system-wide. The default isOption + K; printable keys and F1-F12 require Command, Control, or Option.The real
.appUI flow was exercised on macOS. A human still needs to press the global shortcut from another application with Accessibility allowed and denied; Computer Use cannot synthesize system-wide shortcuts or approve privacy permissions. Known clipboard fallback limits remain documented.