feat(dogfood): add block-authored surface contracts#113
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughThis PR implements DF-069, introducing a block-authored model for DOGFOOD semantic surfaces. It adds a branded registry system to manage surface block contracts, refines i18n scanning to filter machine-only tokens, integrates Storybook into the frame-based shell architecture, and provides comprehensive tests to verify the registry and new Storybook entry point. ChangesDF-069: Block-Authored DOGFOOD
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fac13b3d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return createFramedApp<StorybookModel, StorybookPageMsg>({ | ||
| ctx, | ||
| title, | ||
| initialColumns: ctx.runtime.columns, | ||
| initialRows: ctx.runtime.rows, |
There was a problem hiding this comment.
Set page-first key priority for framed Storybook app
Switching the Storybook entrypoint to createFramedApp without overriding keyPriority causes frame bindings to win over page bindings for shared keys like j/k/d/u/[/] (the frame keymap reserves these for shell scroll/tab actions), so the Storybook page never receives several documented navigation shortcuts. In practice this regresses keyboard navigation compared to the previous standalone app while the footer still advertises those keys; set keyPriority: 'page-first' (or remap conflicting shortcuts) to keep Storybook controls functional.
Useful? React with 👍 / 👎.
Summary
Adds DF-069 block-authored DOGFOOD surface contracts as a bounded ten-slice stack. DOGFOOD now has a local branded block registry for semantic product surfaces, block contracts for title/navigation/article/block-preview/guide-inspector/settings/Storybook workbench, and coverage proving the required surfaces are registered without discovery-time rendering.
This also moves the standalone Storybook entrypoint onto the AppFrame shell so it no longer ships as a parallel bespoke TUI, while keeping rendering/lifecycle policy out of this PR.
Non-goals
Validation
npm test -- --run tests/cycles/DF-069/dogfood-block-registry.test.ts tests/cycles/DF-027/storybook-workstation.test.tsnpm run typecheck:testnpm run docs:inventorygit diff --checknpm run lintnpm run verify:interactive-examplesnpm run dogfood:i18n:debtnpm test— 311 files, 3505 tests passedPre-push also reran
typecheck:test, fullnpm test, and scripted interactive example smoke successfully.Summary by CodeRabbit
Release Notes
New Features
Documentation