Skip to content

Enforce 300 ft minimum separation for CL1/CL2/CL3 in cloud-levels.lua #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Enforce 300 ft minimum separation for CL1/CL2/CL3 in cloud-levels.lua #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c26651
Initial plan
Copilot Jun 5, 2026
57ae8da
fix: enforce cloud layer spacing in cloud-levels
Copilot Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 50 additions & 1 deletion himan-scripts/cloud-levels.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,22 @@ local sct = 0.35
local bkn = 0.55
local dz = 300

local function IsBknLayer(cov)
return not IsMissing(cov) and cov >= bkn
end

local function DropLayer(bases, tops, covs, idx)
for j = idx, 2 do
bases[j] = bases[j + 1]
tops[j] = tops[j + 1]
covs[j] = covs[j + 1]
end

bases[3] = missing
tops[3] = missing
covs[3] = missing
end

local ceiling = luatool:Fetch(current_time, current_level, ceil, current_forecast_type)

maxHdata= {}
Expand Down Expand Up @@ -356,6 +372,40 @@ for i = 1, #base1 do
end
end

for i = 1, #base1 do
local bases = { base1[i], base2[i], base3[i] }
local tops = { top1[i], top2[i], top3[i] }
local covs = { cov1[i], cov2[i], cov3[i] }
local layer_changed = true

while layer_changed do
layer_changed = false

for j = 1, 2 do
if not IsMissing(bases[j]) and not IsMissing(bases[j + 1]) and bases[j + 1] - bases[j] < dz then
if IsBknLayer(covs[j]) or not IsBknLayer(covs[j + 1]) then
DropLayer(bases, tops, covs, j + 1)
else
DropLayer(bases, tops, covs, j)
end

layer_changed = true
break
end
end
end

base1[i] = bases[1]
base2[i] = bases[2]
base3[i] = bases[3]
top1[i] = tops[1]
top2[i] = tops[2]
top3[i] = tops[3]
cov1[i] = covs[1]
cov2[i] = covs[2]
cov3[i] = covs[3]
end

-- write output
p = param("CL1-FT")
result:SetValues(base1)
Expand Down Expand Up @@ -386,4 +436,3 @@ p = param("CLCOV3-0TO1")
result:SetValues(cov3)
result:SetParam(p)
luatool:WriteToFile(result)