Fast export feature (md2html) ready to merge #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as discussed I would move the keybindings to add checkbox elements to something more specific like |
|
Additionally, what do you think about introducing a variable to enable/disable the plugin keybindings? This could be used by user that wish to just the bindings they need. |
|
saro
approved these changes
Aug 5, 2019
fmount
force-pushed
the
fast_export
branch
3 times, most recently
from
5f9626a to
7f59962
Compare
fmount
force-pushed
the
fast_export
branch
2 times, most recently
from
5f78f57 to
36d8537
Compare
Since we need to enable the cbox mappings in different scenarios (e.g. :e *.notes), a default cbox mapping is moved in an appropriate function, so we can control the phase that occur when a *BufRead* or a *BufNewFile* event is received. This change also includes the ability to enable and disable the plugin default key mapping and it exposes a global variable to meet the requirements. We also changed the default keybindings to add cbox(es) to something more specific, providing an example section in the README file. In order to have a minimum amount of acceptance tests, this commit adds the cbox checklist that must pass to allow a PR to get merged. We improved our automation on PR events adding mergify with the following rules: 1. Test passed (travis) 2. Approvers >=2 Signed-off-by: fmount <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we need to enable the cbox mappings in different scenarios (e.g. :e *.notes), the cbox mapping is moved in a init function, so we can handle better the init phase when BufRead and BufNewFile events occur.
The feature is also rebased on master and all the core functions are moved in autoload section.