Skip to content

Make FMT_STRING redundant when FMT_USE_CONSTEVAL is enabled #4612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2025
+5 −1
Merged

Make FMT_STRING redundant when FMT_USE_CONSTEVAL is enabled #4612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54f7d6d
Make FMT_STRING redundant when FMT_USE_CONSTEVAL is enabled
friedkeenan Nov 20, 2025
66d2730
Move FMT_USE_CONSTEVAL check to FMT_STRING directly
friedkeenan Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion include/fmt/format.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4257,7 +4257,11 @@ class format_int {
* // A compile-time error because 'd' is an invalid specifier for strings.
* std::string s = fmt::format(FMT_STRING("{:d}"), "foo");
*/
#define FMT_STRING(s) FMT_STRING_IMPL(s, fmt::detail::compile_string)
#if FMT_USE_CONSTEVAL
# define FMT_STRING(s) s
#else
# define FMT_STRING(s) FMT_STRING_IMPL(s, fmt::detail::compile_string)
#endif // FMT_USE_CONSTEVAL

FMT_API auto vsystem_error(int error_code, string_view fmt, format_args args)
-> std::system_error;
Expand Down
Loading