Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minitest-stub-const is not use anywhere #143

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

voxik
Copy link
Contributor

@voxik voxik commented Jun 24, 2024

According to log, it wasn't ever used.

@voxik
Copy link
Contributor Author

voxik commented Jun 24, 2024

The test matrix would probably deserve some update 🤔

@ekohl
Copy link
Contributor

ekohl commented Jun 24, 2024

Yes, and overall #140 is one we need to finish because currently all tests are failing. Though I've been thinking about pinning the dependency in the short term.

@voxik
Copy link
Contributor Author

voxik commented Jun 24, 2024

because currently all tests are failing. Though I've been thinking about pinning the dependency in the short term.

Yes, ruby-libvirt 0.8.2 should fix the test failures. I think this is the issue:

$ ruby -r libvirt -e '::Libvirt::Domain.new()'
-e:1:in `new': allocator undefined for Libvirt::Domain (TypeError)
        from -e:1:in `<main>'

@voxik
Copy link
Contributor Author

voxik commented Jun 24, 2024

Ah, see your discussion in https://gitlab.com/libvirt/libvirt-ruby/-/merge_requests/35 now

and according to log, it wasn't ever used.
@ekohl
Copy link
Contributor

ekohl commented Jul 12, 2024

I've pinned it and taken the liberty to rebase your PR.

@ekohl ekohl merged commit 978096a into fog:master Jul 12, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants