Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting cpu mode again #156

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Aug 26, 2024

The value for cpu.dig(:model, :name) is always nil since that's the condition in the if statement. It was intended to still respect the cpu mode option passed in.

Fixes: 7a3a46b ("Prefer CPU host pass through over explicit models")

@ekohl
Copy link
Contributor Author

ekohl commented Aug 26, 2024

#157 aims to fix RuboCop.

The value for `cpu.dig(:model, :name)` is always `nil` since that's the
condition in the `if` statement. It was intended to still respect the
cpu mode option passed in.

Fixes: 7a3a46b ("Prefer CPU host pass through over explicit models")
@ekohl ekohl merged commit 11f3821 into fog:master Aug 26, 2024
7 checks passed
@ekohl ekohl deleted the fix-setting-cpu-mode branch August 26, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants