Update default video device to vga #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For over a decade the cirrus driver has been considered outdated and the vga driver is preferred. A common alternative is qxl, but that implies the use of spice which isn't shipped in at least RHEL. It leaves out the vram and relies on libvirt to set a sane default. Link: https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/
geemus
approved these changes
Feb 26, 2025
|
Do we need to release this? |
|
I didn't have a chance to test this yet so I'd appreciate doing that before we release |
|
@ekohl No rush from me, I just didn't want to drop the ball. I think you can release also, so feel free to do so whenever you are ready (or ping me if I need to do it). |
|
I checked, and everything works fine. I was able to create a new Libvirt host with different types of video, and everything worked as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For over a decade the cirrus driver has been considered outdated and the vga driver is preferred. A common alternative is qxl, but that implies the use of spice which isn't shipped in at least RHEL.
It leaves out the vram and relies on libvirt to set a sane default.
At this moment I haven't tested it, but it came out of #71.
Link: https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/