Some V8 methods were deprecated or removed #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on the latest version of V8
|
Can I ask why did you change managed_destroy() signature adding the isolate parameter that is not used in the code? |
|
Also, the V8 I have on my system (Debian unstable) right now doesn't have that overloads. I will merge this when I get them. |
|
These changes were needed to get it to compile on Arch. The signature change on 62 was my mistake, didn't intend for that to go into this pull request. Apologize for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of this libvroomjs were not compiling with the latest V8 libraries. I've changed the method calls to use their non-deprecated equivalents. Tested working under Arch Linux.