fix(dashboard): fix M.have_plugin for mini.nvim explicitly#2631
Open
dpetka2001 wants to merge 1 commit intofolke:mainfrom
Open
fix(dashboard): fix M.have_plugin for mini.nvim explicitly#2631dpetka2001 wants to merge 1 commit intofolke:mainfrom
M.have_plugin for mini.nvim explicitly#2631dpetka2001 wants to merge 1 commit intofolke:mainfrom
Conversation
18e2967 to
c8c30d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently
M.have_pluginonly checks if the plugin name is inspec.plugins. When a user hasmini.nviminstalled that is not sufficient as its modules don't get enabled until theirsetupfunction is called. When they are setup, usually a global table for each module is present. Formini.sessionsit's_G.MiniSessions.Thus, it's better to check for the global table when
mini.nvimis installed by a user to check if a module is actually setup.Related Issue(s)
Fixes #2630
Screenshots