Open
Conversation
Makes workarounds like this no longer necessary: https://github.com/BirdeeHub/nix-wrapper-modules/blob/48b4a74b16a800f57c4ef4c1b10cfe46bb7847d3/templates/neovim/init.lua#L306-L347
Author
|
Actuallly this may be a bug in lazygit [ -z "$NVIM" ] && (nvim -- {{dir}}) || (nvim --server "$NVIM" --remote-send "q" && nvim --server "$NVIM" --remote-tab {{dir}})I think they have their logic wrong here, the () don't look like they are doing what the author intended. Regardless, using vim.v.progpath has guarantees that just using the nvim command does not and we should implement these here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes workarounds like this no longer necessary:
https://github.com/BirdeeHub/nix-wrapper-modules/blob/48b4a74b16a800f57c4ef4c1b10cfe46bb7847d3/templates/neovim/init.lua#L306-L347
I have had this fixed for a few months in my own config with this method and it has solved my annoyance. Realized it was easier to extract than I thought.