[pull] master from GaijinEntertainment:master#967
Merged
Conversation
Reorganize CompilationError per a tag-composition naming discipline (flat enum, mechanically-derivable enumerator names), retag every emit site in src/ accordingly, and add Program::deduplicateErrors() that runs after the parse-time error sort. Why: examples/wip.das emitted 9 errors for a single bug (one missing 'MyEnum.' qualifier). Eight of those nine were downstream noise from follow-on / mid-inference passes. Sites also carried inconsistent cerr values for the same condition and many defaulted to 'unspecified'. The audit captures the per-site mapping in doc/internal/. Dedup rules (after sort, applied program-wide): 1. Collapse adjacent byte-identical entries (append " (xN)"). 2. Same line, same cerr -> keep first (append " (+N more on this line)"). 3. Same line, drop unspecified entries when any coded entry exists. 4. Cross-program: drop *_not_resolved_yet family when any primary error exists. Identified by the dedicated 31300-31399 numeric range. Wired into ast_parse.cpp at both sort sites - covers Program::compile, das compile_file/compile bindings, and any other path that hits parse. Phase D (verbose plumbing for InferTypes::verbose) gated 14 follow-on sites whose work is safe to skip on intermediate passes; ~38 candidates were left unchanged because gating broke runtime invariants. Test sweep: 111 tests/**/*.das renumbered via the legacy map, plus multi-line expect-directive consolidation. dastest 7944/7944 green, test_aot 7338/7338 green. wip.das now reports exactly one error. Audit artifacts under doc/internal/: - error_audit.csv (1116 sites) - error_audit_design.md (naming discipline + transition plan) - error_audit_legacy_map.tsv (per-site mapping) - error_audit_taxonomy.md (range layout) - error_audit_recategorize.tsv, _verbose_gate.tsv, _wording.tsv, _uniques.tsv Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
compiler: error reporting audit, retag, and Program::deduplicateErrors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )