Skip to content

FIO-9761: fixed an issue where fontawesome icons do not appear #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

FIO-9761: fixed an issue where fontawesome icons do not appear #124

merged 1 commit into from
Mar 4, 2025

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Mar 4, 2025 •
edited
Loading

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9761

Description

What changed?

Do not use bi and fa icon classes together because they override styles for each other and icons do not display at all.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit 082565b into main Mar 4, 2025
5 checks passed
@brendanbond brendanbond deleted the FIO-9761-fixed-icons branch March 4, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendanbond brendanbond brendanbond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanyaGashtold @brendanbond