2.3.x: FIO-9964: fixed an issue where getComponent returns wrong component when the form includes several components with the same key #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9964
Description
What changed?
When the form has several components with the same key (e.g. components with paths 'repeatedKey' and 'container.repeatedKey'), and you try to get the component using the key 'repeatedKey', the getComponent always returns the component with this key that goes the last in the eachComponent iteration, that is the component with path 'container.repeatedKey'. So, there is no way to get the 'repeatedKey' component. This PR made it so that getComponent returns the component that matches first within the eachComponent iteration. If someone needs to get the 'container.repeatedKey' component, instead of the key, the path should be passed to getComponent.
This fix is for 2.3.x only.
The getComponent in formio/[email protected] works fine because it did not make the key comparison.
The getComponent in core master and [email protected] works fine because those branches have far more changes in pathing/hidden logic and the getComponent is totally refactored.
How has this PR been tested?
Manually + tests
Checklist: