Edit database connections by jbpoulsen · Pull Request #8 · formulahendry/vscode-mysql

jbpoulsen · 2017-12-06T22:41:31Z

You can now edit a database connection, regardless if you right click it in the Tree or run the command "Edit Connection". If you run the command from the Command Palette, the user will have to select which MySQL connection he wants to edit. The same has been added for the "Delete Connection" command.

…the user select af connection from a quick pick list

…hed correctly when retrieveing the value for editing

…et the user pick a connection from a quick pick menu

formulahendry · 2017-12-10T12:28:20Z

src/common/utility.ts

+            connectionNode.editConnection(context, mysqlTreeDataProvider);
+        } else {
+            // No connection has been selected, let the user pick one
+            const connections = context.globalState.get<{ [key: string]: IConnection }>(Constants.GlobalStateMySQLConectionsKey);


Pick connection logic is similar in deleteConnection and editConnection. Please merge them

formulahendry · 2017-12-10T12:29:12Z

src/model/connectionNode.ts

+    public async editConnection(context?: vscode.ExtensionContext, mysqlTreeDataProvider?: MySQLTreeDataProvider) {
+        AppInsightsClient.sendEvent("editConncetion");
+
+        const host = await vscode.window.showInputBox({ prompt: "The hostname of the database", placeHolder: "host", ignoreFocusOut: true, value: this.host });


This logic is similar to addConnection. Please meege them

formulahendry · 2017-12-10T12:33:06Z

src/model/connectionNode.ts

        mysqlTreeDataProvider.refresh();
    }
+
+    public async editConnection(context?: vscode.ExtensionContext, mysqlTreeDataProvider?: MySQLTreeDataProvider) {


context??

mysqlTreeDataProvider??

formulahendry · 2017-12-10T12:36:49Z

src/common/utility.ts

+                const selectedConnection = connections[selectedConnectionId];
+
+                if (selectedConnection !== undefined) {
+                    const dummyNode = new ConnectionNode(selectedConnectionId, selectedConnection.host, selectedConnection.user, selectedConnection.password,


Is it good practice to do this?

Maybe not.. but should we move the edit/delete methods away from the connectionNode and onto the connection object instead?
We could change the IConnection to an abstract class instead, and implement the methods in here instead?

…selecting a connection

jbpoulsen · 2017-12-21T21:34:18Z

@formulahendry Can you look into merging the changes? I also added the ability to "Drop table" from the Tablenode

formulahendry · 2017-12-22T13:51:19Z

package.json

                    "group": "mysql@1"
+                },
+                {
+                    "command": "mysql.editConnection",


Put this before mysql.deleteConnection

formulahendry · 2017-12-22T13:55:52Z

src/model/tableNode.ts

+            return;
+        }
+
+        AppInsightsClient.sendEvent("drop table");


formulahendry · 2017-12-22T13:58:02Z

src/model/tableNode.ts

+        };
+        Global.activeConnection = connection;
+
+        Utility.runQuery(sql, connection);


How about refreshing the table list after deletion is successful?

How do i refresh the databaseNode from inside the tableNode class? I want to call:

mysqlTreeDataProvider.refresh(databaseNode);

How can i get the "parent" databaseNode for a tableNode?

You could pass databaseNode to constructor of tableNode

Alright ill look into that

formulahendry · 2017-12-22T15:28:08Z

src/model/connectionNode.ts

+        };
+        const editConnection = await Utility.createConnectionFromInput(context, copyFrom);
+
+        if (editConnection !== undefined) {


This logic is similar to addConnection. Please help merge them.

Merge them into a addOrEditConnection method?
Should the metod(s) be placed on the connectionNode or the mysqlTreeDataProvider class?

We could wrap these similar code snippet into a method into https://github.com/formulahendry/vscode-mysql/blob/master/src/common/utility.ts

(We still keep editConnection in connectionNode and addConnection in mysqlTreeDataProvider, and call shared method in utility)

formulahendry · 2017-12-22T15:39:09Z

src/common/utility.ts

+            }
+        }
+
+        await vscode.window.showQuickPick(items).then(async (selection) => {


Better to use: const selection = await vscode.window.showQuickPick(items)

formulahendry · 2017-12-22T15:40:12Z

src/common/utility.ts

+        await vscode.window.showQuickPick(items).then(async (selection) => {
+            // the user canceled the selection
+            if (!selection) {
+                return selectedConnection;


could be just return

formulahendry · 2017-12-22T15:42:06Z

src/common/utility.ts

+                return selectedConnection;
+            }
+
+            const selectedConnectionId = Object.keys(connections)[items.indexOf(selection)];


What if there are two connections have the same host and user?

You would still get the correct selection from the pick menu.. but you wont be able to differ from the two when the menu is shown.. how would you enable anyone to see the difference between two connections with the same host and user? showing the internal id of the connection wont be to much use for the user.

If we could still get the correct selection from the pick menu, then it will be OK. No extra change needed.

jbpoulsen added 4 commits December 5, 2017 22:05

Working on CRUD operations

fc471e7

Support calling Edit Connection from the Command Palette, by letting …

10e0ebc

…the user select af connection from a quick pick list

Removing dublicate code and made sure that the password would be fetc…

a7dff3d

…hed correctly when retrieveing the value for editing

Handle Delete Connection without having selected a connection node. L…

4c7fc22

…et the user pick a connection from a quick pick menu

formulahendry reviewed Dec 10, 2017

View reviewed changes

jbpoulsen added 3 commits December 10, 2017 22:40

Reuse code for creating/adding a new connection. Also reuse code for …

69dab38

…selecting a connection

Rename Utility.createConnection to Utility.createMySQLConnection

2472efd

Added ability to drop table

9e90c2a

formulahendry reviewed Dec 22, 2017

View reviewed changes

package.json

"group": "mysql@1"

},

{

"command": "mysql.editConnection",

Copy link

Owner

formulahendry Dec 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this before mysql.deleteConnection

formulahendry reviewed Dec 22, 2017

View reviewed changes

src/model/tableNode.ts

return;

}

AppInsightsClient.sendEvent("drop table");

Copy link

Owner

formulahendry Dec 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropTable

formulahendry reviewed Dec 22, 2017

View reviewed changes

Conversation

jbpoulsen commented Dec 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbpoulsen commented Dec 21, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jbpoulsen Dec 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jbpoulsen Dec 22, 2017 •

edited

Loading