Fix intel compiler installation when "assume yes" is not set as an apt default
#121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you attempt to use
setup-fortran.shon a base Ubuntu image, installing the Intel compilers will currently die asapt-get installis run without the-yargument (assume yes). All other instances ofapt-get installinsetup-fortran.shhave the-y. It looks to have been accidentally missed here.This PR adds in the missing
-yto allow the intel compiler to be installed in all cases.Note that it works when running on GitHub Actions'
ubuntu-latestdocker image as that hasaptconfigured to always assume yes by default: https://github.com/actions/runner-images/blob/2a8403091c994d6b63e292facecd23b7212c6ccb/images/ubuntu/scripts/build/configure-apt.sh#L20-L21