-
Notifications
You must be signed in to change notification settings - Fork 188
Add the parse of access
in mode
of the open
function, to close #465.
#519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @zoziha. Though potentially useful (other than for fixing the logger), I'm not convinced that these are necessary. A downside is that it complicates the API--we're now adding the 4th (Fortran-specific) letter to the syntax. It's a development and maintenance cost for us, and a learning cost for the user. The upside is that it'd now work with the stdlib logger, and users who want to use I wonder if we should deprecate |
My feeling is similar to @milancurcic in that the beauty of the |
Okay, I think what you said is correct and reasonable. It seems that we should try to modify the |
FWIW I agree with @milancurcic and @certik regarding the additional letters in I think we discussed with @wclodius2 the differences between |
I am on travel again. Travel and catching up on activities delayed by travel, makes it hard to code and document the code. Right now my coding is focussed on hash functions and hash tables. I had thought I was caught up with the coding for hashes, but SMHasher added some more tests (particularly for bad seeds), that showed problems with some of the hash codes I had adapted, and added some hash codes that were better than what I was using, so I have been redoing my hash codes. When I get these into |
@wclodius2 Nice that you are working on the hash codes. If you need some help, don't hesitate to ask for it. |
Thank you for your comments. It seems that this PR is unnecessary, and I will cancel this PR. |
sequential
anddirect
access
support in theopen
function.Description
To fix #465 , I think
open
as a more basic function, there are three types of access (sequential, direct, stream
) are supported in the fortran syntax, so keepingstream
as the default and adding support forsequential and direct
is currently acceptable.