fixed codepane horizontal scroll #787
Conversation
lib/widgets/previewer_codegen.dart
Outdated
| SelectionArea( | ||
| child: SingleChildScrollView( | ||
| controller: controllerV, | ||
| child: IntrinsicHeight( |
There was a problem hiding this comment.
is the IntrinsicHeight widget needed here?
There was a problem hiding this comment.
nope because of constrained box this widget is not necessary here.. Sorry for this oversight .Actaully i was exploring for something which can increase the height of text/singlechildscrollview to its parent box's height efficiently and i tried many things (ignore if i failed to make you understand). i just forget to clean this!
Should I remove this and push another commit?
There was a problem hiding this comment.
Got it 👍🏼.
Yes, push a commit and remove it.
Apart from that the PR seems fine and the solution works.
There was a problem hiding this comment.
@DenserMeerkat one more thing, the drawerwidth is set to zero. can you confirm if this fits with the intended user experience?
There was a problem hiding this comment.
Also, the drawerwidth is set to zero. can you confirm if this fits with the intended user experience?
I think you can remove the drawerWidth property instead of setting it to 0—by default, it will assign a small value to it (e.g., 20) based on the screen size.
There was a problem hiding this comment.
Also, the drawerwidth is set to zero. can you confirm if this fits with the intended user experience?
I think you can remove the
drawerWidthproperty instead of setting it to0—by default, it will assign a small value to it (e.g., 20) based on the screen size.
The scroll experience is not very good... Setting it to 0 is better but limits the drawer...Let's wait for mentor's suggestion.
|
Thanks @badnikhil @Udhay-Adithya @DenserMeerkat |
Glad to contribute! will be dropping a PR for Alamofire-Swift soon . |
PR Description
changed the drawerwidth and modified the codegenpreviewer
Now the text/singlechildscrollview takes full height of the box ensuring scroll works around the whole box instead of just the text
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.
OS on which you have developed and tested the feature?