Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Leaflet OSM tile layer to use the current recommended HTTPS OpenStreetMap tile URL pattern. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since you’re updating the tile URL to HTTPS, consider also updating the attribution link to use
https://osm.org/copyrightfor consistency and to avoid mixed-content issues in strict environments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since you’re updating the tile URL to HTTPS, consider also updating the attribution link to use `https://osm.org/copyright` for consistency and to avoid mixed-content issues in strict environments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
1ca61be to
1445e70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #31, this change updates the OSM Tile Server URL scheme to us the recommended string.
Summary by Sourcery
Enhancements: