Skip to content

Conversation

marcnause
Copy link
Contributor

@marcnause marcnause commented Oct 14, 2025

Fixes: #2966

When the workflow detects that a new version of Flutter is available, it will create a PR which updates the Flutter version of the project.

This PR changes the target branch of the PR created by the workflow to the current default branch called "flutter".

Summary by Sourcery

Chores:

  • Update the GitHub Actions flutter_upgrade workflow to target the "flutter" branch instead of "development"

Copy link
Contributor

sourcery-ai bot commented Oct 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The GitHub Actions workflow snippet for auto-upgrading Flutter has been updated to target the new default branch “flutter” instead of “development” when creating pull requests.

Flow diagram for PR creation with new target branch

flowchart TD
    Start([Start Workflow]) --> Detect["Detect new Flutter version"]
    Detect --> Branch["Create upgrade branch"]
    Branch --> PR["Create PR to flutter branch"]
    PR --> End([End])
Loading

File-Level Changes

Change Details Files
Change PR target branch in workflow
  • Replace --base development with --base flutter in the gh pr create command
.github/workflows/flutter_upgrade.yml

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Build Status

Build successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/18508515647/artifacts/4269629655.

Screenshots

Android Screenshots
iPhone Screenshots
iPad Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow flutter_upgrade creates PR with wrong target branch

1 participant