feat: Update Share App to include all platform links (#3023)#3080
feat: Update Share App to include all platform links (#3023)#3080moksha-hub wants to merge 1 commit intofossasia:developmentfrom
Conversation
Update the shareApp localization string to include download links for all supported platforms instead of just the menu title text: - Android: Google Play Store link - iOS: App Store link - Windows & Linux: GitHub releases link - Website: https://pslab.io This ensures users sharing the app provide comprehensive download information for recipients on any platform. Fixes fossasia#3023
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the English localization to provide a comprehensive, multi‑platform share message for the “Share App” action, including store and website links for all supported platforms. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider moving the app store and website URLs into a shared constants/config file rather than hardcoding them directly in the localization string so they can be maintained in a single place.
- Including emojis in the share text may not render consistently across all platforms or accessibility tools; you may want to provide a more neutral, text-only variant or ensure screen readers handle this well.
- The share message is quite long and platform-specific; you might want to confirm that this formatting degrades gracefully on smaller screens and non-mobile platforms (e.g., line breaks and bullet markers).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider moving the app store and website URLs into a shared constants/config file rather than hardcoding them directly in the localization string so they can be maintained in a single place.
- Including emojis in the share text may not render consistently across all platforms or accessibility tools; you may want to provide a more neutral, text-only variant or ensure screen readers handle this well.
- The share message is quite long and platform-specific; you might want to confirm that this formatting degrades gracefully on smaller screens and non-mobile platforms (e.g., line breaks and bullet markers).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Hi, a process note. We have automatic Copilot PR reviews enabled on this repository. These reviews are only triggered if the contributor has GitHub Copilot enabled and an active license on their own account. Please enable Copilot in your GitHub settings if you have access. In many regions, free licenses are available through educational institutions or developer programs. Enabling Copilot helps us speed up the auto review process and reduces manual review overhead for the core team. |
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the “Share App” experience by replacing a generic share text with a richer, cross-platform message containing download links for Android, iOS, desktop releases, and the PSLab website.
Changes:
- Updates the English localization value for
shareAppto a multi-line, link-rich message intended for sharing. - Adds/updates a large set of English ARB localization entries in
lib/l10n/app_en.arb.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "autoscan" : "Autoscan", | ||
| "selectSensor" : "Select Sensor", | ||
| "notConnected" : "Not Connected", | ||
| "autoScanHint" : "Use Autoscan button to find connected sensors to PSLab device", | ||
| "noSensorDetected" : "No sensors detected", | ||
| "screenNotImplemented" : "screen not implemented yet", | ||
| "timeGap" : "Time gap", | ||
| "pslabNotConnected" : "PSLab not connected", | ||
| "clearData" : "Clear Data", | ||
| "numberOfSampes" : "No. of samples", | ||
| "pressure" : "Pressure", | ||
| "temperature" : "Temperature", | ||
| "bmp180" : "BMP180", | ||
| "plot" : "Plot", |
There was a problem hiding this comment.
There’s inconsistent JSON formatting in this ARB (some keys use "key" : "value" while most use "key": "value"). Reformatting the file with a standard JSON formatter will reduce churn in future diffs and make it easier to maintain/review localization changes.
| "autoscan" : "Autoscan", | |
| "selectSensor" : "Select Sensor", | |
| "notConnected" : "Not Connected", | |
| "autoScanHint" : "Use Autoscan button to find connected sensors to PSLab device", | |
| "noSensorDetected" : "No sensors detected", | |
| "screenNotImplemented" : "screen not implemented yet", | |
| "timeGap" : "Time gap", | |
| "pslabNotConnected" : "PSLab not connected", | |
| "clearData" : "Clear Data", | |
| "numberOfSampes" : "No. of samples", | |
| "pressure" : "Pressure", | |
| "temperature" : "Temperature", | |
| "bmp180" : "BMP180", | |
| "plot" : "Plot", | |
| "autoscan": "Autoscan", | |
| "selectSensor": "Select Sensor", | |
| "notConnected": "Not Connected", | |
| "autoScanHint": "Use Autoscan button to find connected sensors to PSLab device", | |
| "noSensorDetected": "No sensors detected", | |
| "screenNotImplemented": "screen not implemented yet", | |
| "timeGap": "Time gap", | |
| "pslabNotConnected": "PSLab not connected", | |
| "clearData": "Clear Data", | |
| "numberOfSampes": "No. of samples", | |
| "pressure": "Pressure", | |
| "temperature": "Temperature", | |
| "bmp180": "BMP180", | |
| "plot": "Plot", |
| "light": "Light", | ||
| "darkExperimental": "Dark (Experimental)", | ||
| "system": "System", | ||
| "shareApp": "Check out PSLab - Open Source Science Lab!\n\nDownload the app for your platform:\n📱 Android: https://play.google.com/store/apps/details?id=io.pslab\n🍎 iOS: https://apps.apple.com/us/app/pslab/id6740454978\n🖥️ Windows & Linux: https://github.com/fossasia/pslab-desktop/releases\n\nLearn more at https://pslab.io", |
There was a problem hiding this comment.
The PR description/issue expects the navigation drawer “Share App” action to share a cross-platform message, but this ARB string update won’t affect the current Android implementation. MainActivity currently builds shareMessage as only the Play Store URL and strings.xml provides the drawer label; nothing references lib/l10n/app_en.arb. To actually fix #3023, update the share intent to use a localized multi-line string resource (or wire this ARB file into the app’s localization pipeline) and include all platform links there.
| "proxLabel" : "Prox", | ||
| "redLabel" : "Red", | ||
| "mode" : "Mode", | ||
| "configure" : "Configure", |
There was a problem hiding this comment.
This file contains duplicate JSON keys (configure is defined twice). Duplicate keys are ambiguous in JSON and can break/complicate localization tooling (only the last occurrence may win). Please remove the duplicate and keep a single configure entry.
| "configure" : "Configure", |
| "multimeterConfigs": "Multimeter Configurations", | ||
| "multimeterUpdatePeriodHint": "Please provide time interval at which data will be updated (100 ms to 1000 ms)", | ||
| "theme": "Theme", | ||
| "light": "Light", |
There was a problem hiding this comment.
This file contains duplicate JSON keys (light is defined twice). Duplicate keys are ambiguous in JSON and can break/complicate localization tooling (only the last occurrence may win). Please remove the duplicate and keep a single light entry.
| "light": "Light", |
Summary
This PR updates the Share App functionality to include download links for all supported platforms, not just Android.
Problem
The Share App option previously only shared the text "Share App", which wasn't useful for recipients. Users needed a comprehensive message with links to all platform downloads.
Solution
Updated the
shareApplocalization string to include:New Share Message
Testing
Notes
Fixes #3023
Summary by Sourcery
Update the Share App experience to share a comprehensive, cross-platform PSLab download message instead of a generic label.
New Features:
Enhancements: