chore: improve index.html metadata and page title#3095
Open
abhijitbehera710 wants to merge 2 commits intofossasia:flutterfrom
Open
chore: improve index.html metadata and page title#3095abhijitbehera710 wants to merge 2 commits intofossasia:flutterfrom
abhijitbehera710 wants to merge 2 commits intofossasia:flutterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates web app metadata to use proper PSLab branding, more descriptive text, and correct PWA configuration for manifest and HTML head tags. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider updating the
<html>tag to include a matchinglang="en"attribute so the document language is consistent with the manifest and better recognized by browsers and assistive technologies. - Changing
start_urlandscopefrom.to/assumes the app is always hosted at the domain root; if you plan to host it under a subpath, you may want to keep or adjust these values accordingly. - Ensure the meta description in
index.htmland thedescriptioninmanifest.jsonare intentionally aligned in tone and content so search engines and PWA install surfaces present a consistent message.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider updating the `<html>` tag to include a matching `lang="en"` attribute so the document language is consistent with the manifest and better recognized by browsers and assistive technologies.
- Changing `start_url` and `scope` from `.` to `/` assumes the app is always hosted at the domain root; if you plan to host it under a subpath, you may want to keep or adjust these values accordingly.
- Ensure the meta description in `index.html` and the `description` in `manifest.json` are intentionally aligned in tone and content so search engines and PWA install surfaces present a consistent message.
## Individual Comments
### Comment 1
<location path="web/manifest.json" line_range="4-5" />
<code_context>
- "start_url": ".",
+ "name": "PSLab",
+ "short_name": "PSLab",
+ "start_url": "/",
+ "scope": "/",
"display": "standalone",
"background_color": "#0175C2",
</code_context>
<issue_to_address>
**issue (bug_risk):** Using root-relative start_url/scope may break installs when the app is served from a subpath.
Because both `start_url` and `scope` are set to `/`, the PWA will be tied to the domain root. If the app is deployed under a subpath (e.g. `/pslab/` or via a reverse-proxy prefix), install and navigation can break. Prefer a relative `start_url` like `"./"` and set `scope` to match the deployment path, or make these configurable per environment.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Build StatusBuild successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/22568590135/artifacts/5718021465. Screenshots |
b825c82 to
2dac6fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







-1_instruments_screen.png?raw=true)
-2_nav_drawer.png?raw=true)
-3_accelerometer.png?raw=true)
-4_power_source.png?raw=true)
-5_multimeter.png?raw=true)
-6_wave_generator.png?raw=true)
-7_oscilloscope.png?raw=true)
Changes
Screenshots / Recordings
N/A
Checklist:
constants.dartor localization files instead of hard-coded values.dart formator the IDE formatter.flutter analyzeand tests run influtter test.Summary by Sourcery
Improve web app metadata and titles for the PSLab web interface.
Enhancements: