refactor(anvil): use alloy's effective_gas_price in Backend::mined_transaction_receipt
#12639
Conversation
…_transaction_receipt`
mablr
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
|
I think we need to update the failing transaction_receipt test |
| .saturating_add(t.tx().max_priority_fee_per_gas), | ||
| TypedTransaction::Deposit(_) => 0_u128, | ||
| }; | ||
| let effective_gas_price = transaction.effective_gas_price(block.header.base_fee_per_gas); |
There was a problem hiding this comment.
Imo using block.header.base_fee_per_gas as base fee arg is okay and non-breaking, despite self.base_fee() not being used anymore
Indeed after careful review of the blocks init/mining logic, I've not found any scenario where block.header.base_fee_per_gas could be None at this point. Which would mean that in the previous implementation we never had a fallback to the default value self.base_fee() (giving always base_fee_per_gas + max_priority_fee_per_gas for TXs >= eip1559).
So Alloy's impl would "more correct", I guess.
Let me know, if you think i'm wrong.
There was a problem hiding this comment.
If my observation is correct, we could improve robustness by making base_fee non-optional in block header ?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
2 participants
Motivation
#12406 follow-up
Clean up the Anvil codebase by removing custom implementations that are no longer needed.
Solution
effective_gas_priceimpl w/ alloy'sTransactiontrait fnPR Checklist
effective_gas_priceinBackend::mined_transaction_receipt#12639 (comment))