fix(receipt): use from address
#9998
Merged
+39
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `cast receipt`, the failure reason is generated via `eth_call`. However, the `from` address during this call is not correctly set to the one in the transaction. This leads to spurious "Ownable: caller is not the owner" errors, which do not represent the true failure reason for the transaction. This PR fixes that issue. Added a unit test for a Sepolia transaction to capture this case. Without the PR, the revert reason was incorrectly reported as "Ownable: caller is not the owner" instead of the actual revert reason "Counter is too large"
MaxMustermann2
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When calling
cast receipt, the failure reason is generated viaeth_call. However, thefromaddress during this call is not correctly set to the one in the transaction. This leads to spurious "Ownable: caller is not the owner" errors, which do not represent the true failure reason for the transaction.Solution
This PR fixes the above issue by setting the
fromvalue correctly, before invokingeth_call. Included is a unit test for a transaction on Sepolia to demonstrate the difference. Without the PR, the revert reason was incorrectly reported as "Ownable: caller is not the owner" instead of the actual revert reason "Counter is too large".PR Checklist
- [ ] Added Documentation- [ ] Breaking changes