Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): clippy, allow result too large #9999

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Mar 3, 2025

Motivation

Unblock CI due to breaking Clippy changes

Solution

Applies Clippy fixes including suggestion for optimization

Adds result_large_err = "allow" to Cargo.toml as exception

Selectively applies #[allow(clippy::large_enum_variant)] where required, can be used later to look into for optimization - see https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@zerosnacks zerosnacks changed the title fix(`ci): clippy, allow result too large fix(ci): clippy, allow result too large Mar 3, 2025
@zerosnacks zerosnacks added the L-ignore Log: ignore PR in changelog label Mar 3, 2025
@zerosnacks zerosnacks self-assigned this Mar 3, 2025
@zerosnacks zerosnacks enabled auto-merge (squash) March 3, 2025 10:58
@zerosnacks zerosnacks merged commit 19cef98 into master Mar 3, 2025
22 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/fix-clippy branch March 3, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-ignore Log: ignore PR in changelog
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants