feat: Improve error message when trying to redeclare contract using sncast declare #3253

[JoshdfG]

Closes #3253

Introduced changes

• Added a more descriptive error message instead of dumping the whole rpc error directly
• Added a new custom error in sncast/error.rs called ClassAlreadyDeclared(Felt252)

Checklist

• Linked relevant issue
• Updated relevant documentation
• Added relevant tests
• Performed self-review of the code
• Added changes to CHANGELOG.md

[cptartur]

Some of cast tests are failing, probably asserts for outputs need to be updated.

Also run cargo fmt.

[JoshdfG]

@cptartur I'll check those out I ran cargo fmt already that was an oversight

[cptartur]

Looks good, let's wait for the tests to pass

[github-actions]

Hi! This pull request hasn't had any activity for a while, so I am
marking it as stale. It will close in 14
days if it is not updated. Thanks for contributing!

[cptartur]

Thanks for contributing, this will however not address the problem.
The added error handling duplicates the one we already have but the error still persists.

The problem is not due to missing error handling but from the fact that error comes from estimateFee endpoint and not declare.

[cptartur]

The error here is duplicating an handling of AlreadyDeclared we have couple of lines above

[cptartur]

Thanks for contributing, this will however not address the problem. The added error handling duplicates the one we already have but the error still persists.

The problem is not due to missing error handling but from the fact that error comes from estimateFee endpoint and not declare.

I'll be investigating the problem with estimateFee