Skip to content

Conversation

MKowalski8
Copy link
Member

@MKowalski8 MKowalski8 commented Aug 26, 2025

Closes #3109

Introduced changes

  • Remove possibility to set unnamed argument in #[available_gas], e.g #[available_gas(5)]

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@MKowalski8 MKowalski8 requested a review from a team as a code owner August 26, 2025 15:52
Copy link
Contributor

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing, please fix them

l2_gas: 0x3
}
)
snforge_std::_internals::config_types::AvailableResourceBoundsConfig {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the generated code changed and logic for parsing it as well, we'll need to bump the MINIMAL_SNFORGE_STD_VERSION before the release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And since the handling in forge binary changed, we need to backport this change to snforge_std_deprecated otherwise it will not work with forge in my understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove setting available gas with unnamed argument
3 participants