-
Notifications
You must be signed in to change notification settings - Fork 235
Remove setting unnamed argument in #[available_gas]
#3677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
crates/snforge-scarb-plugin/tests/integration/single_attributes/available_gas.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests are failing, please fix them
l2_gas: 0x3 | ||
} | ||
) | ||
snforge_std::_internals::config_types::AvailableResourceBoundsConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the generated code changed and logic for parsing it as well, we'll need to bump the MINIMAL_SNFORGE_STD_VERSION
before the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And since the handling in forge binary changed, we need to backport this change to snforge_std_deprecated
otherwise it will not work with forge in my understanding.
Closes #3109
Introduced changes
#[available_gas]
, e.g#[available_gas(5)]
Checklist
CHANGELOG.md