micro opt: stop emitting __internal_config_statement from test attr #3826
Conversation
maciektr
force-pushed
the
maciektr/plugin-micro-opt
branch
from
6e03d13 to
a0d58c9
Compare
| if snforge_std::_internals::is_config_run() { | ||
| #if_content | ||
|
|
||
| return; |
There was a problem hiding this comment.
I think we should be able to do the same in fuzzer wrapper in wrapper.rs file.
Replace appending #[#internal_config_attr] there with simply creating an another if branch like you did here.
Then we could get rid of the internal config statement attribute entirely.
There was a problem hiding this comment.
cc @ddoktorski @franciszekjob please check if I'm not making things up
There was a problem hiding this comment.
Yup, I think that should be possible to do
There was a problem hiding this comment.
@cptartur This sounds like a good refactoring idea, but tbh I don't think this matters at all apart from code cleanliness - you would normally expect a lot more test attrs than any other.
Especially as I would need to have some equivalent of
that accepts TokenStream instead of FunctionWithBody to keep the logic exactly the same.There was a problem hiding this comment.
We can do that refactor at a later date then.
| if snforge_std::_internals::is_config_run() { | ||
| #if_content | ||
|
|
||
| return; |
There was a problem hiding this comment.
Yup, I think that should be possible to do
3 participants
The test attr is a hot path, so it may make sense to avoid forcing the expansion to happen twice for every test. The time penalty is not big, but seems easy enough to avoid.
Events breakdown for OZ before / after: