Display gas report table #3842
Draft
Display gas report table #3842
+252
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack:
Change managed by git-spice. |
ddoktorski
requested review from
MKowalski8 and
franciszekjob
and removed request for
a team
This was referenced Oct 21, 2025
ddoktorski
force-pushed
the
add-gas-report-logic
branch
2 times, most recently
from
8a9f925 to
8f3b1f6
Compare
ddoktorski
changed the base branch from
add-gas-report-logic
to
share-contracts-data-store
ddoktorski
force-pushed
the
3660-gas-report
branch
2 times, most recently
from
8517806 to
73d507a
Compare
cptartur
reviewed
Oct 24, 2025
Comment on lines
+17
to
+35
| [..]Compiling[..] | ||
| [..]Finished[..] | ||
| Collected 1 test(s) from simple_package package | ||
| Running 0 test(s) from src/ | ||
| Running 1 test(s) from tests/ | ||
| [PASS] simple_package_integrationtest::contract::call_and_invoke (l1_gas: ~0, l1_data_gas: ~[..], l2_gas: ~[..]) | ||
| ╭------------------------+-------+-------+-------+---------+---------╮ | ||
| | HelloStarknet Contract | | | | | | | ||
| +====================================================================+ | ||
| | Function Name | Min | Max | Avg | Std Dev | # Calls | | ||
| |------------------------+-------+-------+-------+---------+---------| | ||
| | get_balance | 13340 | 13340 | 13340 | 0 | 2 | | ||
| |------------------------+-------+-------+-------+---------+---------| | ||
| | increase_balance | 24940 | 24940 | 24940 | 0 | 1 | | ||
| ╰------------------------+-------+-------+-------+---------+---------╯ | ||
| Tests: 1 passed, 0 failed, 0 ignored, [..] filtered out |
There was a problem hiding this comment.
@ddoktorski wdyt about having the contract name centered and the heading cells being merged into one?
| if !contract_info.functions.is_empty() { | ||
| let table = format_table_output(contract_info, name); | ||
| writeln!(f, "\n{table}")?; |
There was a problem hiding this comment.
In what case can there be contract without functions? In case it wasn't actually called in tests or some other ones as well?
Comment on lines
+3
to
+4
| use comfy_table::modifiers::UTF8_ROUND_CORNERS; | ||
| use comfy_table::{Cell, Color, Table}; |
There was a problem hiding this comment.
Glad someone already made a lib for that and we don't have to deal with printing tables
| Cell::new(report_data.gas_stats.min.to_string()).fg(Color::Green), | ||
| Cell::new(report_data.gas_stats.max.to_string()).fg(Color::Red), | ||
| Cell::new(report_data.gas_stats.mean.round().to_string()).fg(Color::Yellow), |
There was a problem hiding this comment.
Not sure about this coloring. I'd rather eventually have some colors based on values or something. Maybe let's just have them all single color or even just white?
Comment on lines
+81
to
+85
| let gas_report = if output_config.gas_report { | ||
| format!("{}", gas_info.report_data) | ||
| } else { | ||
| String::new() | ||
| }; |
There was a problem hiding this comment.
Suggested change
| let gas_report = if output_config.gas_report { | |
| format!("{}", gas_info.report_data) | |
| } else { | |
| String::new() | |
| }; | |
| let gas_report = output_config | |
| .gas_report | |
| .then(|| gas_info.report_data.to_string()) | |
| .unwrap_or_default(); |
Comment on lines
+144
to
+149
| table.add_row(vec![ | ||
| Cell::new("Function Name"), | ||
| Cell::new("Min").fg(Color::Green), | ||
| Cell::new("Max").fg(Color::Red), | ||
| Cell::new("Avg").fg(Color::Yellow), | ||
| Cell::new("Std Dev").fg(Color::Yellow), | ||
| Cell::new("# Calls").fg(Color::Cyan), | ||
| ]); |
There was a problem hiding this comment.
Maybe let's make these header cells bold, with add_attribute(Attribute::Bold)
ddoktorski
force-pushed
the
share-contracts-data-store
branch
from
1c1e984 to
b5ef498
Compare
ddoktorski
force-pushed
the
3660-gas-report
branch
from
73d507a to
7c7f179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3660