Add --partition flag
#3852
Open
Add --partition flag
#3852
+141
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2025
cptartur
approved these changes
Oct 24, 2025
| total: usize, | ||
| } | ||
|
|
||
| #[allow(dead_code)] // TODO: Removed in later PRs |
There was a problem hiding this comment.
Doesn't really matter here but except is safer than allow because it will fail if the condition (dead_code in this case) is not met
Suggested change
| #[allow(dead_code)] // TODO: Removed in later PRs | |
| #[except(dead_code)] // TODO: Removed in later PRs |
Comment on lines
+11
to
+21
| impl Partition { | ||
| #[must_use] | ||
| pub fn index(&self) -> usize { | ||
| self.index | ||
| } | ||
|
|
||
| #[must_use] | ||
| pub fn total(&self) -> usize { | ||
| self.total | ||
| } | ||
| } |
There was a problem hiding this comment.
We could allow just accessing this by making these pub.
You can disallow creating struct instances with pub fields by adding this attribute to it https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute if that's what you wanted to prevent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3548
Stack:
PartitionMessage#3853--partitionflag #3852 ⬅Introduced changes
Add
--partitionflag tosnforgeChecklist
CHANGELOG.md