Refactor metadata module #3860
Open
Refactor metadata module #3860
+160
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksew1
requested review from
ddoktorski and
franciszekjob
and removed request for
a team
This was referenced Oct 23, 2025
ddoktorski
approved these changes
Oct 23, 2025
franciszekjob
approved these changes
Oct 24, 2025
cptartur
reviewed
Oct 24, 2025
There was a problem hiding this comment.
I like these improvements but I wonder if some kind of builder for metadata command wouldn't be more extensible?
The current approach is purpose built for 3 different use-cases and maybe that's enough improvements, but I wonder what you think.
There was a problem hiding this comment.
The idea behind this is to discourage the use of too many options. The issue with the previous solution was that too much freedom resulted in metadata calls that were not consistent.
There was a problem hiding this comment.
Okay, if the rest also disagrees with generalizing this, just disregard my comment.
commit-id:a2fe82e0
ksew1
force-pushed
the
spr/master/a2fe82e0
branch
from
85c48ae to
bddfb28
Compare
ksew1
force-pushed
the
spr/master/e0444c34
branch
from
da6c635 to
b80e7db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack: