Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ADD with COPY in Dockerfile #41

Merged
merged 1 commit into from
Feb 23, 2025
Merged

replace ADD with COPY in Dockerfile #41

merged 1 commit into from
Feb 23, 2025

Conversation

cjber
Copy link
Contributor

@cjber cjber commented Feb 14, 2025

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Changed the ADD instruction to COPY in the Dockerfile. This is recommended for copying normal files or directories into the container, and conforms with best practices.

https://www.docker.com/blog/docker-best-practices-understanding-the-differences-between-add-and-copy-instructions-in-dockerfiles/

@fpgmaas fpgmaas merged commit 4f33102 into fpgmaas:main Feb 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants