Reference original parent, layout params for PiP#1
Merged
Jadeon-FPM merged 1 commit intodevelopfrom May 19, 2025
Merged
Conversation
blwinters
force-pushed
the
fix/exit-pip-layout
branch
from
ba08ef1 to
a4da299
Compare
Collaborator
|
Works well for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issue where the video retains the PiP dimensions after exiting PiP on Android, as discussed in this issue. The bug was introduced in react-native-video 6.9.0 by this commit, specifically the
setIsInPictureInPicture()function.The main part of the fix is holding a reference to the original parent and layout params so that we can reuse those for correct layout/dimensions when the exit-PiP transition is active.
Testing
After merging this PR to use this fork as the package source, change the branch name to
fix/exit-pip-layout, then runyarn nuke, (or deletenode_modulesand the Android build directories), then reinstall packages and run the app on Android.Before the fix, I consistently reproduced the issue, and now it works consistently for me in the emulator.