feat(cosmos): constellation star maps + 11-card encyclopedia wave (v2)#37
feat(cosmos): constellation star maps + 11-card encyclopedia wave (v2)#37frankxai wants to merge 2 commits into
Conversation
- /cosmos/constellations: deterministic SVG sky maps (real J2000 RA/Dec, zero client JS) for Orion, Ursa Major, Crux, Cassiopeia — each chart read in three labeled layers: science / myth / navigation - Encyclopedia 19 → 30 cards: 4 constellations, 3 named stars (Betelgeuse, Sirius, Proxima Centauri), 2 spacecraft (Voyager 1, ISS), 2 concepts (Fusion on Earth, What Stars Teach) - New card kinds: constellation, spacecraft (registry now 12 kinds) - Dual-track prompts on every new card: systems lens + research trail + story seed — one substrate serving research and worldbuilding - Hub nav: fourth view tile (Star Maps); sitemap + featured refresh - Spec: docs/superpowers/specs/2026-07-13-cosmos-platform-expansion.md (phased plan: MCP surface, site agent, Expo app, monetization options) Built on SIP. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HQB4GCtCMEZYwKZ1dzz9T9
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request expands the Starlight Cosmos platform by adding new content cards for constellations, spacecraft, stars, and concepts, along with a platform expansion spec. It introduces a new "Star Maps" visual exploration surface featuring deterministic SVG sky maps rendered via a new ConstellationMap server component. Feedback on the changes suggests adding a defensive guard check in ConstellationMap to prevent potential division-by-zero errors if a constellation is loaded with an empty stars array.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| constellation: Constellation; | ||
| seed?: number; | ||
| }) { | ||
| const { stars, lines } = constellation; |
There was a problem hiding this comment.
To prevent potential division-by-zero errors and rendering issues (resulting in NaN values for coordinates and scale) if a constellation is loaded with an empty stars array, we should add a defensive guard check at the beginning of the component.
| const { stars, lines } = constellation; | |
| const { stars, lines } = constellation; | |
| if (!stars || stars.length === 0) { | |
| return null; | |
| } |
Review finding (PR #37): centroid math divides by stars.length — an empty array would render a NaN-coordinate SVG. Return null instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HQB4GCtCMEZYwKZ1dzz9T9
2 participants
What this ships
The next wave of Starlight Cosmos, extending the 2026-06-11 design spec — the encyclopedia grows, the first visual-exploration surface lands, and the platform vision is captured as a phased plan.
New surface:
/cosmos/constellations/cosmoshub (fourth view tile: "Star Maps") and the sitemap.Encyclopedia: 19 → 30 cards
constellation,spacecraft(registry now spans 12 kinds).Plan doc
docs/superpowers/specs/2026-07-13-cosmos-platform-expansion.md— phased, falsifiable roadmap for the larger vision: Cosmos MCP instarlight-cosmos-engine, embedded site agent, Expo/desktop apps, network visualization, and monetization options with a recommendation (templates now, subscription when the agent exists).Verification
npm run lint— 0 errors (pre-existing warnings only, untouched files)npm run build— green;/cosmos/constellationsprerendered, all 30 card pages SSG'd##sections, closing "Why it matters to a builder")Built on SIP.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HQB4GCtCMEZYwKZ1dzz9T9
Generated by Claude Code