Fix compatibility issues with Node.js 18 and Frappe 16 #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed package-lock.json file. - Updated postinstall script in package.json to ignore engines. - Upgraded Pillow dependency in pyproject.toml to version 11.0.0. - Cleaned up yarn.lock by removing unused entries. - Downgraded @tato30/vue-pdf dependency in frontend/package.json to version 1.9.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several compatibility issues with the Drive application:
Changes
Updated Pillow dependency: Modified pyproject.toml to use Pillow 11.0.0+ (from 10.0.0) to align with Frappe 16.0.0 requirements.
Fixed frontend build error: Added indexHtmlPath to the Vite configuration in frontend/vite.config.js to resolve the build error with frappe-ui:
Apply to vite.config....
Added --ignore-engines flag for yarn installation to bypass Node.js version requirements, allowing the app to work with Node.js 18.x without requiring an upgrade to Node.js 20.
Why these changes are necessary
The application was relying on an older version of Pillow that conflicts with Frappe 16's requirements
The Vite configuration was missing a required parameter for the frappe-ui build plugin
The app had dependencies requiring Node.js 20+ but can function properly with Node.js 18 with appropriate flags
These changes ensure the application can be installed smoothly in environments using Frappe 16 with Node.js 18, without requiring manual adjustments by users.