fix(Leave Application): Validate Attendance marked for *all* present types #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types - Check if attendance for other states other than Present (Should this filter be removed completely?) - Improve user message UX by showing all attendance dates that are marked
gavindsouza
commented
Mar 14, 2025
asmitahase
approved these changes
Mar 20, 2025
|
Hey @asmitahase, backport this to v15? |
asmitahase
added a commit
that referenced
this pull request
Mar 21, 2025
…2863 fix(Leave Application): Validate Attendance marked for *all* present types (backport #2863)
asmitahase
added a commit
that referenced
this pull request
Mar 21, 2025
…2863 fix(Leave Application): Validate Attendance marked for *all* present types (backport #2863)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovery
Creating a Leave Application for an already marked day would overwrite the attendance for it if it was under the status "Work From Home" or "Half Day" but not for "Present".