[Api-Augment] Add js extensions to imports to support esm fully (#1635)

# Goal
To make sure that the generated api-augment javascript can be used
directly with node 16+ and in browsers when using es modules, we needed
to use the full path

See:
https://nodejs.org/dist/latest-v14.x/docs/api/esm.html#esm_resolution_algorithm

# Discussion
- Added the `.js`
- Added the linter to enforce it

Author: wilwade

js/api-augment/.eslintrc

@@ -27,7 +27,7 @@
         "avoidEscape": true
       }
     ],
-    "import/extensions": "off",
+    "import/extensions": ["error", "always", { "ignorePackages": true } ],
     "mocha/no-setup-in-describe": "off",
     "prettier/prettier": "error",
     "no-use-before-define": "off",

js/api-augment/definitions/index.ts

@@ -1,9 +1,9 @@
 // Add a default export here for each definition
 // export { default as pallet } from "./pallet";
 
-export { default as msa } from "./msa";
-export { default as messages } from "./messages";
-export { default as schemas } from "./schemas";
-export { default as statefulStorage } from "./statefulStorage";
-export { default as handles } from "./handles";
-export { default as frequency } from "./frequency";
+export { default as msa } from "./msa.js";
+export { default as messages } from "./messages.js";
+export { default as schemas } from "./schemas.js";
+export { default as statefulStorage } from "./statefulStorage.js";
+export { default as handles } from "./handles.js";
+export { default as frequency } from "./frequency.js";

js/api-augment/index.ts

@@ -1,9 +1,9 @@
 import { ExtDef } from "@polkadot/types/extrinsic/signedExtensions/types";
-import "./interfaces/types-lookup";
-import "./interfaces/augment-api";
-import "./interfaces/augment-types";
-import "./interfaces/index";
-import * as definitions from "./interfaces/definitions";
+import "./interfaces/types-lookup.js";
+import "./interfaces/augment-api.js";
+import "./interfaces/augment-types.js";
+import "./interfaces/index.js";
+import * as definitions from "./interfaces/definitions.js";
 
 /**
  * Build up the types for ApiPromise.create

js/api-augment/interfaces/definitions.ts

@@ -1 +1 @@
-export * from "../definitions";
+export * from "../definitions/index.js";

js/api-augment/scripts/pre-gen.cjs

@@ -22,4 +22,4 @@ files.forEach(file => {
 
 // Pipe over the exports into the interfaces
 const definitionsExportFile = path.join(interfacePath, "definitions.ts");
-fs.writeFileSync(definitionsExportFile, `export * from "../definitions";\n`);
+fs.writeFileSync(definitionsExportFile, `export * from "../definitions/index.js";\n`);

js/api-augment/test/index.test.ts

@@ -1,5 +1,5 @@
 import assert from "assert";
-import { options } from "../index";
+import { options } from "../index.js";
 import { ApiPromise } from "@polkadot/api";
 import { MockProvider } from "@polkadot/rpc-provider/mock";
 import { TypeRegistry } from "@polkadot/types";

js/api-augment/test/types.test.ts

@@ -1,6 +1,6 @@
 import assert from "assert";
 import { TypeRegistry } from "@polkadot/types";
-import { types } from "../index";
+import { types } from "../index.js";
 
 describe("types", function () {
   it("should be able to successfully register", function () {