chore(node): move genesis to runtime #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
github-actions
bot
added
the
metadata-changed
enddynayn
force-pushed
the
chore/move-paseo-genesis-config-to-runtime-issue-2150
branch
from
d4e057a
to
d579469
Compare
github-actions
bot
removed
the
metadata-changed
enddynayn
force-pushed
the
chore/move-paseo-genesis-config-to-runtime-issue-2150
branch
from
d579469
to
b32768d
Compare
enddynayn
changed the title
enddynayn
commented
Sep 12, 2024
enddynayn
commented
Sep 12, 2024
| pub fn get_preset(id: &sp_genesis_builder::PresetId) -> Option<sp_std::vec::Vec<u8>> { | ||
| let genesis = match id.try_into() { | ||
| Ok("development") => development_genesis_config(), | ||
| Ok("paseo") => paseo_genesis_config(), |
wilwade
reviewed
Sep 12, 2024
wilwade
reviewed
Sep 12, 2024
|
|
||
| use sp_runtime::traits::AccountIdConversion; | ||
|
|
||
| pub mod frequency_mainnet_keys { |
There was a problem hiding this comment.
Do we still need this file for benchmarking? If not we can delete
github-actions
bot
added
the
metadata-changed
wilwade
reviewed
Sep 12, 2024
wilwade
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Or make it "development-defaults"?
wilwade
reviewed
Sep 12, 2024
github-actions
bot
removed
the
metadata-changed
enddynayn
force-pushed
the
chore/move-paseo-genesis-config-to-runtime-issue-2150
branch
from
8a78ece
to
5c3ee01
Compare
JoeCap08055
reviewed
Sep 16, 2024
There was a problem hiding this comment.
@enddynayn not sure what I'm supposed to be seeing, but I pulled & built this branch and I don't see the schemas that are supposed to be in the genesis block.
enddynayn
force-pushed
the
chore/move-paseo-genesis-config-to-runtime-issue-2150
branch
from
5c3ee01
to
ddeda53
Compare
enddynayn
force-pushed
the
chore/mv-development-genesis-to-runtime-issue-2149
branch
2 times, most recently
from
7e6423f
to
be72197
Compare
enddynayn
force-pushed
the
chore/move-paseo-genesis-config-to-runtime-issue-2150
branch
from
87df7f8
to
8d8aec5
Compare
github-actions
bot
added
the
metadata-changed
enddynayn
force-pushed
the
chore/move-paseo-genesis-config-to-runtime-issue-2150
branch
from
34e80a4
to
217022c
Compare
github-actions
bot
removed
the
metadata-changed
github-actions
bot
added
metadata-changed
Move the Frequency and Paseo genesis configurations to the runtime. Additionally, refactor the genesis builder for Paseo, Frequency, and Development into a single genesis_builder function.
enddynayn
force-pushed
the
chore/move-paseo-genesis-config-to-runtime-issue-2150
branch
from
4186611
to
d542bd1
Compare
github-actions
bot
removed
the
metadata-changed
This was referenced Sep 30, 2024
github-actions
bot
added
the
metadata-changed
enddynayn
merged commit d47f870
into
chore/mv-development-genesis-to-runtime-issue-2149
27 checks passed
enddynayn
deleted the
chore/move-paseo-genesis-config-to-runtime-issue-2150
branch
enddynayn
restored the
chore/move-paseo-genesis-config-to-runtime-issue-2150
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the genesis builders for Paseo and Frequency, as these are now referenced directly from the generated spec file.
Consolidated Frequency-local and Frequency-no-relay into a single genesis_builder function for improved clarity and maintainability.