Support hidden wifi on windows #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to friedrith#22 friedrith#22
Visible networks caused problems since the promise of the last wifi scan got not resolved. Related to friedrith#22 friedrith#22
Related to friedrith#22 friedrith#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add support for hidden wifis, wifis which do not broadcast there SSID, without breaking existing API usages.
Motivation and Context
Windows does not simply connect to wifis which do not broadcast their SSID (hidden wifis).
The additional flag
<nonBroadcast>true</nonBroadcast>in the profile xml file is required.If the flag is set, this PR adds the nonBroadcast param to the profile xml config file and connects to the wifi.
It also skips the scan for the given wifi because it will not appear in the wifi list, obviously.
This PR is related and should close #22 on Windows.
The missing configuration has been posted on Stackoverflow in this thread:
https://stackoverflow.com/questions/69470100/connect-to-hidden-wifi-using-netsh-commands
Usage examples
Users can now provide an additional parameter to the
connect()method:the default of isHidden is false so that existing code should not break.
How Has This Been Tested?
The code has been tested on Windows 10 with a Wifi without SSID.
Types of changes
New feature (non-breaking change which adds functionality)
Refactorization (non-functional change which improve code readibility)