Skip to content

fix: make Raindrop group folders optional - #93

Merged
frostmute merged 1 commit into
mainfrom
fix/issue-92-group-path-setting
Aug 30, 2026
Merged

fix: make Raindrop group folders optional#93
frostmute merged 1 commit into
mainfrom
fix/issue-92-group-path-setting

Conversation

@frostmute

@frostmute frostmute commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • add an Include Raindrop group in folder path setting under Import & Organization
  • keep the setting enabled by default to preserve the current Group/Collection hierarchy
  • allow users to restore the pre-v1.10 Collection-only layout without losing collectionGroup metadata
  • explain in Obsidian that the setting affects future imports and does not move existing notes
  • document both hierarchy modes and add regression coverage

Closes #92

Testing

  • npm test -- --runInBand (336 tests passed)
  • npm run lint
  • npm run scan-secrets
  • focused group hierarchy, settings, and settings migration tests

Build

Not run: repository agent instructions prohibit building unless explicitly requested.

Summary by CodeRabbit

  • New Features

    • Added a setting under Settings → Make It Rain → Import & Organization to include or omit Raindrop Groups in imported folder paths.
    • Group folders remain enabled by default, using Group/Collection/Subcollection.
    • Disabling the setting restores the Collection/Subcollection layout for future imports while retaining group metadata.
  • Documentation

    • Updated product documentation and user guides with configuration details and behavior.

Copilot AI lite review requested due to automatic review settings August 30, 2026 20:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 13518340-ca5b-43ab-a028-f1d80ee37efc

📥 Commits

Reviewing files that changed from the base of the PR and between 5010f0a and 81ae19d.

📒 Files selected for processing (10)
  • docs/product-specs/group-folder-paths.md
  • docs/product-specs/index.md
  • docs/user-guide/collections.md
  • docs/user-guide/configuration.md
  • src/main.ts
  • src/settings.ts
  • src/types.ts
  • tests/unit/groupHierarchy.test.ts
  • tests/unit/main.test.ts
  • tests/unit/settings.test.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The plugin adds a default-enabled setting that controls whether Raindrop group names appear in imported folder paths. Imports preserve group metadata in both modes. Documentation and tests cover the setting and both layouts.

Changes

Group folder paths

Layer / File(s) Summary
Setting contract and control
src/types.ts, src/settings.ts, tests/unit/main.test.ts, tests/unit/settings.test.ts
Adds the includeGroupInFolderPath setting, defaults it to true, exposes it in Import & Organization, persists changes, and tests the default and UI text.
Conditional import paths
src/main.ts, tests/unit/groupHierarchy.test.ts
Conditionally prepends the group name to imported paths. Group metadata remains available when the group folder is disabled.
Feature documentation
docs/product-specs/group-folder-paths.md, docs/product-specs/index.md, docs/user-guide/collections.md, docs/user-guide/configuration.md
Documents the Group/Collection and Collection-only layouts, future-import scope, and collectionGroup metadata availability.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to 81ae1

The new setting changes the folder hierarchy used for future imports while preserving existing metadata and default behavior. Changing it during an active multi-item import could place items from the same batch under different layouts, so merge is appropriate with explicit owner awareness of this edge case.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: making Raindrop group folders optional.
Linked Issues check ✅ Passed The pull request satisfies issue #92 by adding a setting that disables the extra Raindrop group folder and restores the previous Collection-only path. The default remains enabled, and group metadata r…
Out of Scope Changes check ✅ Passed The code, settings UI, documentation, and regression tests all directly support issue #92. No unrelated changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 6…
Full details: Linked Issues check

Explanation

The pull request satisfies issue #92 by adding a setting that disables the extra Raindrop group folder and restores the previous Collection-only path. The default remains enabled, and group metadata remains available.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 6 files. (4 skipped: 4 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-92-group-path-setting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 81ae19d09d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/user-guide/collections.md
@frostmute
frostmute merged commit 3720052 into main Aug 30, 2026
4 checks passed
@frostmute
frostmute deleted the fix/issue-92-group-path-setting branch August 30, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Path is changed for plugin

2 participants