Repository navigation
docs(adr): amend ADR-0028: first-setup retired without a soak (ADR-0031) - #1246
Merged
Merged
Conversation
ADR-0028's consequences said that first-setup retires after a 14-day soak, that a revert restores first-setup while its deb stays in APT, and that the lab first-login probe gates its lane after 3 green main runs. None holds: the soak was dropped, apt-publisher#32 withdrew every snow-first-setup version from trixie, and the probe is a report-only lab mode (lab ADR-0016). Accepted ADRs are immutable, so ADR-0031 amends ADR-0028: first-setup is retired, a revert needs a republication of the deb first, and snosi documents only the first-login gates it runs. ADR-0028's status points to ADR-0031; AGENTS.md and integration-contracts.md follow. Guard: test/first-login-trigger-test.sh section 7 fails when ADR-0028 keeps the stale text without the amendment pointer, or when ADR-0031 lacks the corrections. AGENTS.md gains the rule that a snosi ADR links another repository's gate instead of stating it; .memory/corrections.jsonl records it.
…e self-checks Cross-review found that section 7 skipped its ADR-0028 assertion when the file was missing or had no stale text. The check is now a function that fails on a missing or unreadable record, and 6 fixture cases prove that it detects a missing ADR-0028 or ADR-0031, a missing amendment pointer, a lost revert path and a missing index entry.
Contributor
Author
Cross-review
Revert testIn a scratch worktree at CI is green at |
frostyard-machines
added
the
ready-for-human
bketelsen
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ADR-0028 (from #1224) has two consequences that no longer hold:
snow-first-setupversion fromtrixie(recordwithdrawals/2026-11-05-snow-first-setup.txt).Accepted ADRs are immutable except for status and successor pointers, so this adds an amending ADR instead of editing ADR-0028.
What
docs/adr/0031-first-setup-retired-without-a-soak.md(Accepted): first-setup is retired with no soak; a revert of ADR-0028 needs apt-publisher to republish the deb first (an image build that lists it now fails when APT resolves packages); snosi documents only the first-login gates it runs (first-login.finalize,test/first-login-trigger-test.sh, and testsuite'sdesktop.featurein the lab container lane). The lab probe's gate status lives in lab.Accepted; its retirement and lab-gate consequences are amended by ADR-0031.docs/README.mdindexes ADR-0031.AGENTS.md: the first-login paragraph names the withdrawn deb and the revert path; the Documentation section adds the rule that a snosi ADR links another repository's gate or schedule instead of stating it.docs/integration-contracts.md:snow-first-setupis withdrawn from APT (ADR-0031).Guard
test/first-login-trigger-test.shsection 7 (already invalidate.yml): fails when ADR-0028 keeps its soak or lab-gate text without the ADR-0031 pointer in its status, when ADR-0031 is missing or lacks the withdrawn deb, the revert path or the lab gate owner, and whendocs/README.mddoes not index ADR-0031. Checked to fail with the old ADR-0028 status and with ADR-0031 removed..memory/corrections.jsonl: 1 line.Checks (local)
bash test/first-login-trigger-test.sh: 99 passed, 0 failed.shellcheck test/first-login-trigger-test.sh: clean.make ci BASE=origin/main: template gate, Node tests,policy-as-code-test,risk-paths-test,build-workflow-permissions-testpass; corrections append-only.No image content changes. No path in
.github/risk-paths.jsonmatches.