-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicates and naming #325
Comments
Good point about those duplicate functions. Too many people contributing without discussing things I guess. About Option.concat, it's the same concept as the built-in |
Don't know how you want to handle things but if you need some help, feel free to ask/contact me. |
shouldn't we name it |
4th variant: let d = Double.TryParse "2" |> toOption https://github.com/fsprojects/FSharpx.Extras/blob/master/src/FSharpx.Extras/Prelude.fs#L89-L92 |
Hi,
First of all, thank you for this helpful library.
I'd like to report here a duplication of the same method with 3 names (ofBoolAndValue, fromTryPattern, tryParseWith).
let a = Double.TryParse "2" |> Option.ofBoolAndValue
let b = Option.fromTryPattern Double.TryParse "2"
let c = Option.tryParseWith Double.TryParse "2"
Also, I was wondering if you should not rename the Option.concat to Option.flatten or Option.switch (to look like Observable.switch) because the name is quite misleading and actually doesn't concat some options.
Cheers
The text was updated successfully, but these errors were encountered: