Skip to content

various fixes #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2017
Merged

various fixes #2929

merged 4 commits into from
Dec 6, 2017

Conversation

@enricosada
Copy link
Collaborator

@enricosada enricosada commented Dec 5, 2017 •
edited
Loading

FIX

  • fix test
    • was removing other package, like nunit.console
    • was removing other package version (one was in use by dotnet test )
  • if test need to change working dir, should restore previous when done

NEW

  • add vscode workspace settings
  • add PAKET_WAIT_DEBUGGER env var to wait for debugger
    if PAKET_WAIT_DEBUGGER is 1, paket will wait at start to a debugger to attach

partial code extracted from #2918

forki
forki approved these changes Dec 5, 2017
View reviewed changes
build.fsx Outdated
let gitRaw = environVarOrDefault "gitRaw" "https://raw.github.com/fsprojects"

let dotnetcliVersion = "2.1.0-preview1-007002"
let dotnetcliVersion = "2.0.3"
Copy link
Member

@forki forki Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that change

@forki
Copy link
Member

forki commented Dec 5, 2017

Appveyor says no

@enricosada
Copy link
Collaborator Author

enricosada commented Dec 5, 2017 •
edited
Loading

seen that. let me fix it, has some issue restoring SourceLink with 2.0.3 seems (in the other PR i have sourcelink disabled).
I'll scrap that and move in another PR

@enricosada
add PAKET_WAIT_DEBUGGER env var to wait for debugger
6b068a5 
if PAKET_WAIT_DEBUGGER is `1`, paket will wait at start to a debugger to attach
@enricosada
if test need to change working dir, should restore previous when done
a97a575
@enricosada
add vscode workspace settings
f99fca8
@enricosada
fix test
8849d0b 
- was removing other package, like nunit.console
- was removing other package version (one was in use by dotnet test )
@enricosada enricosada changed the title various fixes [WIP] various fixes Dec 5, 2017
@enricosada
Copy link
Collaborator Author

enricosada commented Dec 5, 2017 •
edited
Loading

@forki you restarted the appveyor on your account instead of cloudroutine?
anyway is done for me. commit are separated, so fell free to rebase merge, if you wish

@enricosada enricosada changed the title [WIP] various fixes various fixes Dec 5, 2017
@enricosada
Copy link
Collaborator Author

enricosada commented Dec 5, 2017 •
edited
Loading

btw, the .net core sdk install removed earlier is in #2931 , let's see if workaround is ok

@forki forki closed this Dec 6, 2017
@forki forki reopened this Dec 6, 2017
@forki
Copy link
Member

forki commented Dec 6, 2017

Triggered build

@enricosada
Copy link
Collaborator Author

enricosada commented Dec 6, 2017 •
edited
Loading

i seen that before, seems that if the job run on cloudroutine appveyor (there is also one by matth?), these goes on timeout. @forki you have a pro account on https://ci.appveyor.com/project/SteffenForkmann ?

@forki forki merged commit 3664667 into fsprojects:master Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@forki forki forki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enricosada @forki