-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Give reasons for resolving group (#3008) #3302
base: master
Are you sure you want to change the base?
[WIP] Give reasons for resolving group (#3008) #3302
Conversation
@@ -10,6 +10,8 @@ open Chessie.ErrorHandling | |||
open Paket.Logging | |||
open InstallProcess | |||
|
|||
type RTC = DependencyChangeDetection.ResolutionTriggeringChange |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only to bring in the type to avoid having to fully qualify
The alternatives I currently see are
- opening the DependencyChangeDetection module; not sure if we'd want to do that here
- specifying the type and module every time in the pattern match, which seems ugly
- moving the original type somewhere else, like to
Paket.Domain
; not sure if that would be correct
This addresses #3008 opened by @mavnn. I have "surfaced" the information about specific changes that cause the resolver to be run for a group, and when that decision is made, every single individual reason for resolving is listed. One question is what the desired amount of detail for the different cases is. Currently
Is there anything that should have more or less detail? Ignore the individual commits and changes to files other than |
@@ -918,3 +918,5 @@ let main() = | |||
else printError exn | |||
|
|||
main() | |||
|
|||
ignore () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forki That's one of the things to.... ignore. ;-) I used that to set a final breakpoint for debugging and didn't want to sort out what to commit while this is still unfinished. As I said, I'll clean everything up when I finish the PR.
My personal feeling (@forki may have better ideas) is that if the resolver is triggered because of a change to paket.dependencies that's probably expected behaviour and shouldn't produce any output (except maybe with a verbose flag set?). Apart from that, listing every package and why it's triggering the resolver sounds useful to me? |
This is a work in progress to discuss whether this is detailed enough, and a few questions I have about the code.