switch to uv, and modernize CI yaml#58
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
I don't mind to use |
Do you find this works? I would worry about parallel access to the same drive and the weird races this can cause. Every test run had better at least run with a unique prefix and be sure to clean it up. |
Yeah, you're probably right. I did not benchmark this. For a repo of this size, I don't think it matters. I'm used to uv being faster on my other projects hence the statement. To offer some reasons why to use uv:
I've only expanded the Python matrix for unit tests which doesn't access a real drive, and run fully isolated. |
I'm actually against this - we want the CI to fail if a dep breaks current code. Otherwise we wouldn't be aware of real failing installations that users might be experiencing. |
Yeah that makes sense, I should be more careful. I can remove the lockfile and the CI that generates it. Are you still keen on using uv? Or stick to pip |
I don't mind uv, but it would put more responsibility on you, since I barely use it myself. |
|
done! cleaner now |
| description = "File system on GDrive" | ||
| readme = {file = "README.md", content-type = "text/markdown"} | ||
| requires-python = ">=3.10" | ||
| license = { file = "LICENSE" } |
There was a problem hiding this comment.
This was a deprecated license spec and hence raised errors when resolving uv.
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license
SetuptoolsDeprecationWarning: License classifiers are deprecated.
!!
********************************************************************************
Please consider removing the following classifiers in favor of a SPDX license expression:
License :: OSI Approved :: BSD License
See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
| [project.urls] | ||
| Source = "http://github.com/fsspec/gdrive-fsspec" | ||
|
|
||
| [tool.setuptools.packages.find] |
There was a problem hiding this comment.
Added because of
self._finalize_license_expression()
error: Multiple top-level packages discovered in a flat-layout: ['tmp', 'gdrive_fsspec'].
To avoid accidental inclusion of unwanted files or directories,
setuptools will not proceed with this build.
If you are trying to create a single distribution with multiple packages
on purpose, you should not rely on automatic discovery.
Instead, consider the following options:
1. set up custom discovery (`find` directive with `include` or `exclude`)
2. use a `src-layout`
3. explicitly set `py_modules` or `packages` with a list of names
To find more information, look for "package discovery" on setuptools docs.
Summary