RequireMsgSym[_,_,Info] and more #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warn and Info validation options for RequireMsgSym now also invoke scala compiler FontEnds logging.
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
==========================================
- Coverage 91.57% 90.56% -1.01%
==========================================
Files 10 10
Lines 700 710 +10
Branches 11 9 -2
==========================================
+ Hits 641 643 +2
- Misses 59 67 +8
Continue to review full report at Codecov.
|
tribbloid
pushed a commit
to tribbloid/shapesafe
that referenced
this pull request
Apr 21, 2021
|
Sorry I don't know how to write unit test for this case, It appears that there is no coverage for Warn symbol as well, so I doubt if it could be tested |
|
Thanks for the PR. I'll only have time to review it next month. |
tribbloid
pushed a commit
to tribbloid/shapesafe
that referenced
this pull request
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch has the following 2 changes:
add Info as a validation option for RequireMsgSym
Warn and Info validation options for RequireMsgSym now also invoke scala compiler FontEnds logging.
The purpose of 2 is to allow warning and info logs to be identified by any build & code inspection systems, e.g. bloop language server in the following screenshot:
Unfortunately at this moment only INFO seems to be working. WARNING will be omitted by both scalac & bloop. It is probably caused by scala/bug#6910.
If you know the reason for this behaviour please let me know, I'll correct it