This repository was archived by the owner on Jun 9, 2022. It is now read-only.
allow event if targetElement does not exist in the DOM anymore#587
Open
fsiliadin wants to merge 2 commits into
Open
allow event if targetElement does not exist in the DOM anymore#587fsiliadin wants to merge 2 commits into
fsiliadin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I've been working on a bug with an app that uses your library (by the way I have to say it's awesome) and I thought of the following case:
When we are on a popup which displays with a grayout (like a modal) and you click on the grayout to hide the popup (and the grayout of course) and then you click on what was overlayed by the popup, then you have a strange issue: you have to click twice in order to trigger the actual click event. I had a look and it seems like, at the first click after the popup closure, the variable
this.targetElementis still refering to the grayout element that actually disappeared from the dom. That's what my second commit tries to fix.The first commit is just to update the mouseEvent instanciation: https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/initMouseEvent