Allow RobotArm to be controlled with 3d print apps like GCodePrintr... #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ePrintr. - Add relative vs absolute positioning (G91/G90) - Add M105 command (fake temperature) - Use \\n as line ending - Use 115200 baud - Add homing (G28) - Add Get Position (M114) - prefix non-standard output with echo Several fixes: Make compile on Linux work (case sensitive includes), detect NaN, fill valueE, etc.
ftobler
reviewed
May 31, 2020
| return false; | ||
| } | ||
| if (c == '\r') { | ||
| if (c == '\n' || c == '\r') { |
There was a problem hiding this comment.
does not work if \n and \r are sent
ftobler
reviewed
May 31, 2020
|
|
||
| void setup() { | ||
| Serial.begin(9600); | ||
| Serial.begin(115200); |
ftobler
reviewed
May 31, 2020
| @@ -54,7 +54,7 @@ void Interpolation::setInterpolation(Point p1, float v) { | |||
| } | |||
|
|
|||
| void Interpolation::setInterpolation(Point p0, Point p1, float av) { | |||
| v = av; //mm/s | |||
| v = av/60; //convert to mm/s -> 3d printer sw uses mm/min | |||
ftobler
reviewed
May 31, 2020
| if (v < 5) { //includes 0 = default value | ||
| v = sqrt(dist) * 10; //set a good value for v | ||
| if (v < 1) { //includes 0 = default value | ||
| v = sqrt(dist) * 5; //set a good value for v |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes:
Make compile on Linux work (case sensitive includes), detect NaN, fill valueE, etc.