Implement route history further. Add support for html5 history. #14
Conversation
| (defn install-history! [history-impl] | ||
| (reset! history history-impl)) |
There was a problem hiding this comment.
Moved this the to route-history NS. Allows others to create custom implementations of the route history if they choose to.
| @@ -144,9 +135,10 @@ | |||
| (when (gobj/getValueByKeys evt "state") | |||
| (let [event-uid (gobj/getValueByKeys evt "state" "uid")] | |||
| (log/debug "Got pop state event." evt) | |||
| (scf/send! app :com.fulcrologic.statecharts.integration.fulcro.ui-routes/session | |||
| (swap! (:current-uid history) (constantly event-uid)) | |||
There was a problem hiding this comment.
Ensures current-uid is synced with the browser popstate event-uid.
| (-back! [this] | ||
| #?(:cljs | ||
| (do | ||
| (tap> "Going back") | ||
| (cond | ||
| (> (count @uid->history) 1) (do | ||
| (tap> "Going back YAW!") | ||
| (log/debug "Back to prior route" (some-> @uid->history last second)) | ||
| (.back js/history)) | ||
| :else (log/error "No prior route. Ignoring BACK request."))))) | ||
| (-current-route [this] (url->route fulcro-app)) | ||
| (-recent-history [this] @uid->history)) |
There was a problem hiding this comment.
Implemented back to sync the browser back button.
There was a problem hiding this comment.
@awkay I have several changes here for your review. So far these changes syncs up nicely with the browser popstate (back/forward), and drops the user into the appropriate state route from the current URL.
Still broken:
- Reloading form edit breaks the form. We need to sync the sc route param some how.
- Report controls do not update the sc route param
|
So, you've tested that a ui state that had data (from the initial event) and is properly re-started with the same event data? Is that seeming sufficient? I assume that as long as the route state itself is established from outside properly, then any substate that needs to be established will be properly handled by the entry handlers from there. See any edge cases? |
|
Im not confident it works well. I was able to reload the a form ui state by providing the route params ( 
Will share a screen recording with you directly. |
No description provided.